Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2071/Hub-promo-abc-test #583

Merged
merged 9 commits into from Jul 20, 2020

Do not overwrite hub_promo_variant prop after it is first set

  • Loading branch information
wlycdgr committed Jun 10, 2020
commit 33d4d206711bdcc889deb79af8351cdb6c3fbf34
@@ -1115,6 +1115,8 @@ function getAntitrackingTestConfig() {
* @return {Object} Hub promotion configuration parameters
*/
function setupHubPromoABTest() {
if (conf.hub_promo_variant !== 'not_yet_set') return;

if (abtest.hasTest('hub_plain')) {
conf.hub_promo_variant = 'plain';
} else if (abtest.hasTest('hub_midnight')) {
@@ -541,6 +541,7 @@ class Metrics {
return 2;
case 'midnight':
return 3;
case 'not_yet_set':
default:
return 0;
}
ProTip! Use n and p to navigate between commits in a pull request.