Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2090: Fix settings dropdown menu for russian translation #585

Merged
merged 1 commit into from Jul 20, 2020
Merged

GH-2090: Fix settings dropdown menu for russian translation #585

merged 1 commit into from Jul 20, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jul 20, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • The length of the russian bullet copy is pushing everything down into an absolute div. Let's change that div to position: relative and remove the height from the dropdown div to let it size itself

Ticket: https://ghostery.atlassian.net/browse/GH-2090?focusedCommentId=17757
@benstrumeyer
Fix russian translation settings dropdown
Loading status checks…
57cde01
@benstrumeyer benstrumeyer added this to the 8.5.2 milestone Jul 20, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Jul 20, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Jul 20, 2020
@benstrumeyer benstrumeyer self-assigned this Jul 20, 2020
@benstrumeyer benstrumeyer changed the title Fix russian translation settings dropdown GH-2090: Fix settings dropdown menu for russian translation Jul 20, 2020
@wlycdgr
wlycdgr approved these changes Jul 20, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM
@christophertino christophertino merged commit 16769fa into develop Jul 20, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the translations branch Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino