GH-2072: Add subscription interval to ping params and change UpgradePlan CTA link params #586
+28
−14
Conversation
|
Re: the login pin always sending 0 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
subscription intervalparameter to all pings, taken from the account conf variableThe login ping will send a 0 regardless of subscription status. All other pings without refreshing the panel will send the updated value. Let me know if there is a way to fix this
UpgradePlanViewfromsubscription_intervaltointervalto match the query param in checkout-webTicket: https://ghostery.atlassian.net/browse/GH-2072