Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2072: Add subscription interval to ping params and change UpgradePlan CTA link params #586

Merged
merged 8 commits into from Jul 27, 2020

Change subscription_interval to interval to match the query param in …

…checkout web
  • Loading branch information
benstrumeyer committed Jul 27, 2020
commit 247554f192936970158c87fc5146bc8027057ad1
@@ -169,7 +169,7 @@ const UpgradePlanView = (props) => {
// UTM and Query Params
// Subscription_interval is the query param to show monthly/yearly pricing in checkout web
This conversation was marked as resolved by wlycdgr

This comment has been minimized.

@wlycdgr

wlycdgr Jul 27, 2020
Member

Let's update the comment to use the updated interval param name

This comment has been minimized.

@benstrumeyer

benstrumeyer Jul 27, 2020
Author Contributor

Nice catch!

const interval = show_yearly_prices ? 'year' : 'month';
const utmParams = `utm_source=gbe&subscription_interval=${interval}`;
const utmParams = `utm_source=gbe&interval=${interval}`;

const plusCTAButton = (position) => {
const utm_campaign = position === 'top' ? 'c_1' : 'c_2';
This conversation was marked as resolved by wlycdgr

This comment has been minimized.

@wlycdgr

wlycdgr Jul 27, 2020
Member

Could you throw a set of parens around the rvalue to make this a little easier to parse visually?

This comment has been minimized.

@benstrumeyer

benstrumeyer Jul 27, 2020
Author Contributor

Yes, yes I can :D

ProTip! Use n and p to navigate between commits in a pull request.