Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2072: Add subscription interval to ping params and change UpgradePlan CTA link params #586

Merged
merged 8 commits into from Jul 27, 2020
+28 −14
Merged

GH-2072: Add subscription interval to ping params and change UpgradePlan CTA link params #586

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0d645c8
Delete unnecesssary ping params
benstrumeyer Jul 24, 2020
6d1d37b
Add subscription interval to ping params
benstrumeyer Jul 27, 2020
247554f
Change subscription_interval to interval to match the query param in …
benstrumeyer Jul 27, 2020
e873160
Remove null check
benstrumeyer Jul 27, 2020
23fb87b
Change variable name
benstrumeyer Jul 27, 2020
6f72d1b
Fix linter
benstrumeyer Jul 27, 2020
f554c7d
Update comment. Wrap ternary in (), update subscripton_interval ping …
benstrumeyer Jul 27, 2020
2574305
Add semicolon
benstrumeyer Jul 27, 2020
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…

Fix linter

  • Loading branch information
@benstrumeyer
benstrumeyer committed Jul 27, 2020
commit 6f72d1b3bc2883c3c602d8186a28c386082ba0ab
2 src/classes/Metrics.js
View file
Open in desktop
@@ -370,7 +370,7 @@ class Metrics {

// New parameter for Ghostery 8.5.2
// Hub Promo variant
`&hp=${encodeURIComponent(Metrics._getHubPromoVariant().toString())}`;
`&hp=${encodeURIComponent(Metrics._getHubPromoVariant().toString())}` +
// Subscription Interval
`&si=${encodeURIComponent(Metrics._getSubscriptionInterval().toString())}`;
This conversation was marked as resolved by wlycdgr

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr Jul 27, 2020
Member

There's a matching param on the metrics-server side or a PR to add one, yah?

This comment has been minimized.

Sign in to view
@benstrumeyer

benstrumeyer Jul 27, 2020
Author Contributor

Yup, the PR is here. https://github.com/ghostery/metrics_server/pull/25. Good catch, I think we need to update the param name to subscription_interval. Let's do that here to get 8.5.2 out the door quicker

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr Jul 27, 2020
Member

Good idea

ProTip! Use n and p to navigate between commits in a pull request.