Update comment. Wrap ternary in (), update subscripton_interval ping …

…param name

app/hub/Views/UpgradePlanView/UpgradePlanView.jsx

@@ -167,12 +167,12 @@ const UpgradePlanView = (props) => {
 	};
 
 	// UTM and Query Params
-	// Subscription_interval is the query param to show monthly/yearly pricing in checkout web
+	// interval is the query param to show monthly/yearly pricing in checkout web
 	const interval = show_yearly_prices ? 'year' : 'month';
 	const params = `utm_source=gbe&interval=${interval}`;
 
 	const plusCTAButton = (position) => {
-		const utm_campaign = position === 'top' ? 'c_1' : 'c_2';
+		const utm_campaign = (position === 'top' ? 'c_1' : 'c_2');
 		const plusCheckoutLink = `${globals.CHECKOUT_BASE_URL}/plus?${params}&utm_campaign=intro_hub_${utm_campaign}`;
 
 		return (
@@ -183,7 +183,7 @@ const UpgradePlanView = (props) => {
 	};
 
 	const premiumCTAButton = (position) => {
-		const utm_campaign = position === 'top' ? 'c_3' : 'c_4';
+		const utm_campaign = (position === 'top' ? 'c_3' : 'c_4');
 		const premiumCheckoutLink = `${globals.CHECKOUT_BASE_URL}/premium?${params}&utm_campaign=intro_hub_${utm_campaign}`;
 
 		return (

src/background.js

@@ -823,7 +823,7 @@ function onMessageHandler(request, sender, callback) {
 			.catch((err) => {
 				log('LOGIN ERROR', err);
 				callback({ errors: _getJSONAPIErrorsObject(err) });
-			});
+			})
 		return true;
 	}
 	if (name === 'account.register') {

src/classes/Metrics.js

@@ -372,7 +372,7 @@ class Metrics {
 			// Hub Promo variant
 			`&hp=${encodeURIComponent(Metrics._getHubPromoVariant().toString())}` +
 			// Subscription Interval
-			`&si=${encodeURIComponent(Metrics._getSubscriptionInterval().toString())}`;
+			`&subscription_interval=${encodeURIComponent(Metrics._getSubscriptionInterval().toString())}`;
 
 		if (CAMPAIGN_METRICS.includes(type)) {
 			// only send campaign attribution when necessary