Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2071 A/B testing console error #588

Merged
merged 1 commit into from Jul 28, 2020
Merged

GH-2071 A/B testing console error #588

merged 1 commit into from Jul 28, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jul 28, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • pm is undefined when logging into plus or premium account and the user has a midnight promo modal A/B test

Steps to replicate:

  • Set conf.hub_promo_variant = 'midnight' in background#setupHubPromoABTest()
  • Load the extension (automatically routed to the Home View with Premium promo modal shown)
  • Log into a plus account and be redirected to the HomeUpgradePlanView
  • Click the Home View and notice the error in the console

image

Ticket: https://ghostery.atlassian.net/browse/GH-2071

@benstrumeyer benstrumeyer added this to the 8.5.2 milestone Jul 28, 2020
@benstrumeyer benstrumeyer requested a review from christophertino Jul 28, 2020
@benstrumeyer benstrumeyer self-assigned this Jul 28, 2020
@christophertino christophertino merged commit 153ee6b into develop Jul 28, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2071 branch Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants