Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove finally from background #589

Merged
merged 1 commit into from Jul 29, 2020
Merged

Remove finally from background #589

merged 1 commit into from Jul 29, 2020

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jul 29, 2020

Removes finally from the background.js code, because it is not supported in some of the older Chrome and Opera versions the extension supports.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Remove finally from background
Loading status checks…
8074690
@wlycdgr wlycdgr requested a review from zarembsky as a code owner Jul 29, 2020
@wlycdgr wlycdgr requested a review from christophertino Jul 29, 2020
@christophertino
christophertino approved these changes Jul 29, 2020
View changes
@christophertino christophertino merged commit 02dbe2b into develop Jul 29, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the bugfix/remove-finally branch Jul 29, 2020
@christophertino christophertino added this to the 8.5.2 milestone Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino