Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-2040: Update Insights in-app promo CTA link #593

Closed
wants to merge 4 commits into from
Closed

GD-2040: Update Insights in-app promo CTA link #593

wants to merge 4 commits into from

Conversation

@caseyoppenheim
Copy link

@caseyoppenheim caseyoppenheim commented Aug 11, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@caseyoppenheim
modifications to extension ffor 3 a11y tests
Loading status checks…
b4e4ff3
@caseyoppenheim
still need to fix eslintrc.js, this isn't the final commit
fdc6ac1
@caseyoppenheim
fixed eslintrc.js and enabled the three a11y tests
Loading status checks…
d948ca3
@caseyoppenheim
changed link in PromoModal.jsx
Loading status checks…
f04b5d3
@caseyoppenheim caseyoppenheim requested review from christophertino, wlycdgr and ghostery/ghostery as code owners Aug 11, 2020
@fcjr fcjr changed the base branch from master to develop Aug 11, 2020
@caseyoppenheim caseyoppenheim deleted the GD-2040 branch Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

@ghostery/ghostery Ghostery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@caseyoppenheim