Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-2040: Update Insights in-app promo CTA link #593

Closed
wants to merge 4 commits into from
Closed
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

still need to fix eslintrc.js, this isn't the final commit

  • Loading branch information
caseyoppenheim committed Jul 7, 2020
commit fdc6ac1c7d7bbd11c701fc2d4430d352e07efa7c
@@ -101,6 +101,8 @@ module.exports = {
"render"
]
}],
},


// Plugin: JSX-A11y
'jsx-a11y/alt-text': [0],
@@ -113,5 +115,5 @@ module.exports = {
'jsx-a11y/label-has-associated-control': [0], //ToDo: enable this check. Throws 2 errors, should work.
'jsx-a11y/media-has-caption': [0], //ToDo: enable this check. Need Captions to enable.
'jsx-a11y/anchor-has-content': [1], //ToDo: enable this check. Need anchor text to enable.
},
};

}
@@ -41,16 +41,6 @@ const SteppedNavigation = (props) => {
: <NavLink aria-label="Stepped naivation link to another page" to={`${i}`} key={`nav-${i}`}><span className="a11y-label">Inactive stepped navigation link span text</span></NavLink>);
}

// ilya's notes:
/* for (let i = 1; i <= totalSteps; i++) {
// Use <a> without an href prop to prevent a call to history with the same URL
circles.push((i === activeIndex) ?
// VoiceOver on Mac does NOT read the span text
<a aria-label="Stepped navigation link to current page" className="active" key={`nav-${i}`}><span className="a11y-label">Active link span text</span></a>
: <NavLink aria-label="Stepped navigation link to another page" to={`${i}`} key={`nav-${i}`}><span className="a11y-label">Inactive stepped navigation link span text</span></NavLink>);
}
*/

return (
<div className="row align-center">
<div className="columns small-12">
ProTip! Use n and p to navigate between commits in a pull request.