GH-2040: Update Insights in-app promo CTA link #594
Closed
Conversation
caseyoppenheim
commented
Aug 11, 2020
|
caseyoppenheim
requested review from
christophertino,
jsignanini,
wlycdgr,
zarembsky and
ghostery/ghostery
as
code owners
fcjr
changed the title
fcjr
changed the title
| @@ -76,7 +76,7 @@ class PromoModal extends React.Component { | |||
| break; | |||
| case INSIGHTS: | |||
| sendMessage('ping', 'promo_modals_insights_upgrade_cta'); | |||
| url = `https://checkout.${DOMAIN}.com/insights?utm_source=gbe&utm_campaign=${utm_campaign}`; | |||
| url = `https://www.ghostery.com/insights/?utm_source=gbe&utm_campaign=${utm_campaign}`; | |||
fcjr
Aug 13, 2020
Member
looks like we do actually have a staging website now, rather than doubling dev work lets wait till support for this is done by @benstrumeyer in #595 to update this PR.
looks like we do actually have a staging website now, rather than doubling dev work lets wait till support for this is done by @benstrumeyer in #595 to update this PR.
|
Closing in favor of #595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.