Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2040: Update Insights in-app promo CTA link #594

Closed
wants to merge 4 commits into from
+1 −1
Closed

GH-2040: Update Insights in-app promo CTA link #594

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc281ba
changed link in PromoModal.jsx
caseyoppenheim Aug 11, 2020
9c9955e
now it goes to the correct link
caseyoppenheim Aug 11, 2020
1993002
changed the value of utm_campaign
caseyoppenheim Aug 12, 2020
bea7635
Merge branch 'develop' into GD2040
fcjr Aug 12, 2020
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…

changed the value of utm_campaign

  • Loading branch information
@caseyoppenheim
caseyoppenheim committed Aug 12, 2020
commit 1993002a1ee01e3de20642da5638de4bbeb1a2e7
2 app/shared-components/PromoModal/PromoModal.jsx
View file
Open in desktop
@@ -76,7 +76,7 @@ class PromoModal extends React.Component {
break;
case INSIGHTS:
sendMessage('ping', 'promo_modals_insights_upgrade_cta');
url = `https://www.ghostery.com/insights/?utm_source=gbe&utm_campaign=in_app_upgrade=${utm_campaign}`;
url = `https://www.ghostery.com/insights/?utm_source=gbe&utm_campaign=${utm_campaign}`;

This comment has been minimized.

Sign in to view
@fcjr

fcjr Aug 13, 2020
Member

looks like we do actually have a staging website now, rather than doubling dev work lets wait till support for this is done by @benstrumeyer in #595 to update this PR.
break;
default:
}
ProTip! Use n and p to navigate between commits in a pull request.