Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2040: Update Insights in-app promo CTA link #594

Closed
wants to merge 4 commits into from
+1 −1
Closed

GH-2040: Update Insights in-app promo CTA link #594

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc281ba
changed link in PromoModal.jsx
caseyoppenheim Aug 11, 2020
9c9955e
now it goes to the correct link
caseyoppenheim Aug 11, 2020
1993002
changed the value of utm_campaign
caseyoppenheim Aug 12, 2020
bea7635
Merge branch 'develop' into GD2040
fcjr Aug 12, 2020
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next
Loading status checks…

changed link in PromoModal.jsx

  • Loading branch information
@caseyoppenheim
caseyoppenheim committed Aug 11, 2020
commit cc281bab11a86417c6be195acdde6358a345bf57
2 app/shared-components/PromoModal/PromoModal.jsx
View file
Open in desktop
@@ -76,7 +76,7 @@ class PromoModal extends React.Component {
break;
case INSIGHTS:
sendMessage('ping', 'promo_modals_insights_upgrade_cta');
url = `https://checkout.${DOMAIN}.com/insights?utm_source=gbe&utm_campaign=${utm_campaign}`;
url = `https://www.ghostery.${DOMAIN}.com/insights/?utm_source=gbe&utm_campaign=in_app_upgrade=${utm_campaign}`;
This conversation was marked as resolved by fcjr

This comment has been minimized.

Sign in to view
@fcjr

fcjr Aug 11, 2020
Member

this will expand to https:///www.ghostery.ghostery.com/insights/?utm_source=gbe&utm_campaign=in_app_upgrade=<utms> take a look at the value of DOMAIN from line 26 of this file. as this URL does not change depending on environment we should probably not be using any conditional domains for this URL

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr Aug 11, 2020
Member

^ Good point, I agree we should just use string literals since the value is the same on staging and prod
break;
default:
}
ProTip! Use n and p to navigate between commits in a pull request.