GH-2086, GH-2084, GH-2040: Update intro hub Get Plus, Midnight & Insights Modal CTA link

[benstrumeyer]

• Have you followed the guidelines in CONTRIBUTING.md?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you added an explanation of what your changes do?
• Does your submission pass tests?
• Did you lint your code prior to submission?

• Intro Hub Get Plus should go to the plus description page
• Intro Hub's Ghostery Midnight modal should link to the landing page
• Intro Hub's Ghostery Insights modal should link to the landing page

Tickets:

• https://ghostery.atlassian.net/browse/GH-2083
• https://ghostery.atlassian.net/browse/GH-2084

[wlycdgr]

LGTM

[christophertino]

We should use www.${DOMAIN}.com here as well to point at the staging website.

@wlycdgr This probably exists in lots of places.

[fcjr]

We should use www.${DOMAIN}.com here as well to point at the staging website.

@wlycdgr This probably exists in lots of places.

While we are at it we should update the promo component to get the domains from Globals instead setting it at the top of this file.

[wlycdgr]

We should use www.${DOMAIN}.com here as well to point at the staging website.

@wlycdgr This probably exists in lots of places.

@christophertino I'll check other places. We originally implemented it that way in this component & changed it by mistake, so hopefully it will not be so many.

[wlycdgr]

lgtm

[fcjr]

looks good to me, however one thing with using GHOSTERY_BASE_URL is that both these links will always result in an immediate redirect ghostery.com -> www.ghostery.com. Not sure if it matters but wanted to point it out incase @wlycdgr or @christophertino have any concerns with that

[wlycdgr]

looks good to me, however one thing with using GHOSTERY_BASE_URL is that both these links will always result in an immediate redirect ghostery.com -> www.ghostery.com. Not sure if it matters but wanted to point it out incase @wlycdgr or @christophertino have any concerns with that

In Chrome I don't see a user-visible redirect at all; in Firefox, there is one in the address bar, but there's no flicker, so I have no issue with it from a UX perspective anyway. I did notice a bug in Firefox though where the panel does not close after the Midnight landing page opens! I'll make a ticket. I made a ticket.

[christophertino]

It shouldn't matter since the request is redirected in nginx. If we wanted to be really verbose we could make another global variant as a www url, but I don't think it's necessary.

Approved