Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2035: Update In-App Plus/Premium pricing #596

Merged
merged 5 commits into from Aug 17, 2020
Merged

GH-2035: Update In-App Plus/Premium pricing #596

merged 5 commits into from Aug 17, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Aug 13, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Update copy in In-App Promotional panel
  • Update copy in Intro Hub Plus Tab
  • Update midnight promo to be lowercase

Ticket: https://ghostery.atlassian.net/browse/GH-2035
@benstrumeyer
Update in app plus/premium pricing
Loading status checks…
cc7679a
@benstrumeyer
Revert to 7-day free trial string
Loading status checks…
716af8a
@benstrumeyer benstrumeyer added this to the 8.5.3 milestone Aug 13, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Aug 13, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Aug 13, 2020
@benstrumeyer benstrumeyer self-assigned this Aug 13, 2020
@benstrumeyer
Fix linter
Loading status checks…
28071d2
@benstrumeyer
Update snapshot
Loading status checks…
5f30a23
@wlycdgr
wlycdgr reviewed Aug 17, 2020
View changes
app/hub/Views/PlusView/__tests__/__snapshots__/PlusView.test.jsx.snap Show resolved Hide resolved
app/hub/Views/PlusView/__tests__/__snapshots__/PlusView.test.jsx.snap Show resolved Hide resolved
@wlycdgr
wlycdgr approved these changes Aug 17, 2020
View changes
@christophertino
Merge branch 'develop' into GH-2035
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
bef6eb1
@christophertino christophertino merged commit 124d633 into develop Aug 17, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2035 branch Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Feature Enhancement
Projects
None yet
Milestone
8.5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino