Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2035: Update In-App Plus/Premium pricing #596

Merged
merged 5 commits into from Aug 17, 2020
Merged
Changes from all commits
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

@@ -1729,7 +1729,7 @@
"message": "Resolve issues fast with our Priority help desk service - and more perks to come"
},
"hub_supporter_manifesto": {
"message": "We strive to deliver the best privacy protection services to our users free of cost. While we do not charge for our browser extension, you may choose to support us through a small monthly subscription. Join us in our mission by upgrading to Ghostery Plus - and unlock cool perks along the way!"
"message": "We strive to deliver the best privacy protection services to our users free of cost. While we do not charge for our browser extension, you may choose to support us through a monthly subscription of $4.99. Join us in our mission by upgrading to Ghostery Plus - and unlock cool perks along the way!"
},
"hub_supporter_feature_theme_description": {
"message": "Customize the Ghostery colors for a new visual experience! Introduced through popular request. Check out our special Dark Blue theme, and more to come."
@@ -1944,7 +1944,7 @@
"message": "Themes"
},
"subscribe_pitch": {
"message": "While Ghostery is free, you can choose to support us through a small monthly subscription in exchange for special perks like color themes, personal tracking statistics, and more. Join our mission and subscribe!"
"message": "While Ghostery is free, you can choose to support us through a monthly subscription of $4.99 in exchange for special perks, like color themes, personal tracking statistics, and more. Join our mission and subscribe!"
},
"subscribe_pitch_spring": {
"message": "Like what we do? Support us and unlock new spring themes, personal tracking insights, and other special perks by upgrading to Ghostery Plus!"
@@ -2513,7 +2513,7 @@
"message": "Try Ghostery Midnight"
},
"seven_day_free_trial": {
"message": "7 Day Free Trial"
"message": "7-day free trial"
},
"spring_is_here": {
"message": "Spring is here!"
@@ -97,9 +97,7 @@ class PlusView extends Component {
</div>
<div className="PlusView__manifestoContainer">
<div className="PlusView__manifestoBackground row align-center">
<div className="PlusView__manifestoText columns small-12 medium-10 large-8 text-center">
{t('hub_supporter_manifesto')}
</div>
<div dangerouslySetInnerHTML={{ __html: t('hub_supporter_manifesto') }} className="PlusView__manifestoText columns small-12 medium-10 large-8 text-center" />
</div>
</div>
<div className="PlusView--addPaddingTop PlusView--addPaddingBottom">
@@ -97,9 +97,12 @@ exports[`app/hub/Views/PlusView component Snapshot tests with react-test-rendere
>
<div
className="PlusView__manifestoText columns small-12 medium-10 large-8 text-center"
>
hub_supporter_manifesto
</div>
dangerouslySetInnerHTML={
Object {
"__html": "hub_supporter_manifesto",
}
This conversation was marked as resolved by wlycdgr
Comment on lines +101 to +103

This comment has been minimized.

@wlycdgr

wlycdgr Aug 17, 2020
Member

how come you're using this Object syntax here vs dangerouslySetInnerHTML={{ __html:...?

This comment has been minimized.

@wlycdgr

wlycdgr Aug 17, 2020
Member

Never mind, I missed that these are in snap files!

}
/>
</div>
</div>
<div
@@ -426,9 +429,12 @@ exports[`app/hub/Views/PlusView component Snapshot tests with react-test-rendere
>
<div
className="PlusView__manifestoText columns small-12 medium-10 large-8 text-center"
>
hub_supporter_manifesto
</div>
dangerouslySetInnerHTML={
Object {
"__html": "hub_supporter_manifesto",
}
This conversation was marked as resolved by wlycdgr
Comment on lines +433 to +435

This comment has been minimized.

@wlycdgr

wlycdgr Aug 17, 2020
Member

Same question re: the Object syntax. No complaints I just haven't seen it done this way, so, curious.

This comment has been minimized.

@wlycdgr

wlycdgr Aug 17, 2020
Member

Never mind, I missed that these are in snap files!

}
/>
</div>
</div>
<div
ProTip! Use n and p to navigate between commits in a pull request.