Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2152: Shorten subscription_interval uninstall URL param to si #600

Merged
merged 2 commits into from Aug 25, 2020
Merged

GH-2152: Shorten subscription_interval uninstall URL param to si #600

merged 2 commits into from Aug 25, 2020

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Aug 25, 2020

Our uninstall URL currently exceeds the 255 character limit imposed by runtime.setUninstallURL. This stopgap fix brings the char count under the limit for now.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Shorten uninstall url by shorterning subscription_interval param name…
Loading status checks…
322752c 
… to si
@wlycdgr wlycdgr requested a review from jsignanini as a code owner Aug 25, 2020
@wlycdgr wlycdgr requested a review from fcjr Aug 25, 2020
@fcjr
Merge branch 'develop' into GH-2152
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3c758e9
@fcjr
fcjr approved these changes Aug 25, 2020
View changes
@christophertino christophertino added this to the 8.5.3 milestone Aug 25, 2020
@christophertino christophertino merged commit fde426c into develop Aug 25, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2152 branch Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcjr fcjr

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wlycdgr @fcjr @christophertino