Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2152: Shorten subscription_interval uninstall URL param to si #600

Merged
merged 2 commits into from Aug 25, 2020
+1 −1
Merged

GH-2152: Shorten subscription_interval uninstall URL param to si #600

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
322752c
Shorten uninstall url by shorterning subscription_interval param name…
wlycdgr Aug 25, 2020
3c758e9
Merge branch 'develop' into GH-2152
fcjr Aug 25, 2020
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next
Loading status checks…

Shorten uninstall url by shorterning subscription_interval param name… 

… to si
  • Loading branch information
@wlycdgr
wlycdgr committed Aug 25, 2020
commit 322752c4cb14c1ea04ccb9e06969b9ad73fc7671
2 src/classes/Metrics.js
View file
Open in desktop
@@ -372,7 +372,7 @@ class Metrics {
// Hub Promo variant
`&hp=${encodeURIComponent(Metrics._getHubPromoVariant().toString())}` +
// Subscription Interval
`&subscription_interval=${encodeURIComponent(Metrics._getSubscriptionInterval().toString())}` +
`&si=${encodeURIComponent(Metrics._getSubscriptionInterval().toString())}` +
// Product ID Parameter
`&pi=${encodeURIComponent('gbe')}`;

ProTip! Use n and p to navigate between commits in a pull request.