GH-2100, GH-2097: Onboarding test 2 #603
Merged
Conversation
leuryr
requested review from
benstrumeyer,
christophertino,
wlycdgr and
ghostery/extension
as
code owners
|
One bug I noticed: in the alternate Hub scenario, clicking on the Ghostery icon at the top of the sidebar makes the "this is the tab you're in" triangle indicator disappear EDIT: Moot / resolved because icon now links to website |
|
A few small things + we MAY need to keep the Metrics parts of the code for the old A/B test. Even if not, we should use a new Metrics query param name for this new test instead of |
| import SideNavigationView from './SideNavigationView'; | ||
| import globals from '../../../../src/classes/Globals'; | ||
|
|
||
| const { IS_CLIQZ, BROWSER_INFO } = globals; | ||
| const IS_ANDROID = (BROWSER_INFO.os === 'android'); | ||
|
|
||
| // Flag to display alternate hub view (used in A/B testing) |
wlycdgr
Sep 15, 2020
Member
Same deal as above - could we add a reference to the specific ticket(s)?
Same deal as above - could we add a reference to the specific ticket(s)?
|
NOTE: This PR should not be merged into develop until after 8.5.3 has been released EDIT: Change of plan. This should go into 8.5.3. |
wlycdgr
changed the title
wlycdgr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Includes the addition of a new A/B test, which displays a different Hub layout on install for users.