Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2100, GH-2097: Onboarding test 2 #603

Merged
merged 7 commits into from Sep 22, 2020

Merge in develop without clobbering updates on either end

  • Loading branch information
wlycdgr committed Sep 22, 2020
commit 0aafef5e424bd331c809bddb84cc5f1959c8a29d
@@ -16,10 +16,13 @@ import PropTypes from 'prop-types';
import ClassNames from 'classnames';
import { NavLink } from 'react-router-dom';
import QueryString from 'query-string';
import globals from '../../../../src/classes/Globals';

// Flag to display alternate hub view (used in A/B testing)
This conversation was marked as resolved by wlycdgr

This comment has been minimized.

@wlycdgr

wlycdgr Sep 15, 2020
Member

Can we add a reference to the specific tickets to the comment so it's easier for us to remember what's going on?

const ah = (QueryString.parse(window.location.search).ah === 'true') || false;

const { GHOSTERY_BASE_URL } = globals;

/**
* Helper render function for rendering a list item for the Navigation Main section
* @param {Object} item the menu list item
@@ -102,7 +105,13 @@ const SideNavigationView = (props) => {

return (
<div className={containerClassNames}>
<NavLink to="/" className={topClassNames} />
<a
href={GHOSTERY_BASE_URL}
aria-label="Ghostery website"
rel="noopener noreferrer"
target="_blank"
className={topClassNames}
/>
<div className={menuClassNames}>
{menuItems.map(item => _renderMenuItem(item, disableNav))}
</div>
You are viewing a condensed version of this merge commit. You can view the full changes here.
ProTip! Use n and p to navigate between commits in a pull request.