Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2168: Change hub logo link #605

Merged
merged 3 commits into from Sep 21, 2020
Merged

GH-2168: Change hub logo link #605

merged 3 commits into from Sep 21, 2020

Conversation

@leuryr
Copy link
Contributor

@leuryr leuryr commented Sep 18, 2020 •
edited

This PR changes the link for the Ghostery hub logo to direct the user to the Ghostery website in a new tab, instead of the root of the Intro Hub. As a result, I've also updated the snapshot for the component's test.

The Ghostery website that opens will be either the staging site or the prod site depending on whether the DEBUG environment variable is true or false.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
leuryr added 2 commits Sep 17, 2020
@leuryr
Link to Ghostery site from logo in Hub
Loading status checks…
8fb9e03
@leuryr
Update component snapshot
Loading status checks…
ae994f2
@leuryr leuryr requested a review from benstrumeyer as a code owner Sep 18, 2020
@leuryr leuryr changed the title Gh 2168/hub logo link GH-2168: change hub logo link Sep 18, 2020
@leuryr leuryr changed the title GH-2168: change hub logo link GH-2168: Change hub logo link Sep 18, 2020
@wlycdgr
wlycdgr approved these changes Sep 18, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM
app/hub/Views/SideNavigationView/SideNavigationView.jsx Show resolved Hide resolved
@christophertino christophertino added this to the 8.5.3 milestone Sep 21, 2020
@christophertino
Merge branch 'develop' into GH-2168/hub-logo-link
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
831f23c
@christophertino christophertino merged commit 34c6223 into develop Sep 21, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2168/hub-logo-link branch Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

@benstrumeyer benstrumeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@leuryr @wlycdgr @christophertino