Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2168: Change hub logo link #605

Merged
merged 3 commits into from Sep 21, 2020
+25 −16
Merged

GH-2168: Change hub logo link #605

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fb9e03
Link to Ghostery site from logo in Hub
leuryr Sep 17, 2020
ae994f2
Update component snapshot
leuryr Sep 18, 2020
831f23c
Merge branch 'develop' into GH-2168/hub-logo-link
christophertino Sep 21, 2020
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

11 app/hub/Views/SideNavigationView/SideNavigationView.jsx
View file
Open in desktop
@@ -15,6 +15,9 @@ import React from 'react';
import PropTypes from 'prop-types';
import ClassNames from 'classnames';
import { NavLink } from 'react-router-dom';
import globals from '../../../../src/classes/Globals';

const { GHOSTERY_BASE_URL } = globals;

/**
* Helper render function for rendering a list item for the Navigation Main section
@@ -96,7 +99,13 @@ const SideNavigationView = (props) => {

return (
<div className={containerClassNames}>
<NavLink to="/" className={topClassNames} />
<a
href={GHOSTERY_BASE_URL}
aria-label="Ghostery website"
This conversation was marked as resolved by wlycdgr

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr Sep 18, 2020
Member

Nice aria-label add!

This comment has been minimized.

Sign in to view
@leuryr

leuryr Sep 18, 2020
Author Contributor

Thanks! It helps that the linter yells at you if you don't include one when you don't have text for your a tag, haha.
rel="noopener noreferrer"
target="_blank"
className={topClassNames}
/>
<div className="SideNavigation__menu flex-child-grow flex-container flex-dir-column">
{menuItems.map(item => _renderMenuItem(item, disableNav))}
</div>
30 app/hub/Views/SideNavigationView/__tests__/__snapshots__/SideNavigationView.test.jsx.snap
View file
Open in desktop
@@ -5,11 +5,11 @@ exports[`app/hub/Views/SideNavigationView component More Snapshot tests with rea
className="SideNavigation flex-container flex-dir-column"
>
<a
aria-current="page"
className="SideNavigation__top active"
href="/"
onClick={[Function]}
style={Object {}}
aria-label="Ghostery website"
className="SideNavigation__top"
href="https://ghosterystage.com"
rel="noopener noreferrer"
target="_blank"
/>
<div
className="SideNavigation__menu flex-child-grow flex-container flex-dir-column"
@@ -25,11 +25,11 @@ exports[`app/hub/Views/SideNavigationView component Snapshot tests with react-te
className="SideNavigation flex-container flex-dir-column"
>
<a
aria-current="page"
className="SideNavigation__top active"
href="/"
onClick={[Function]}
style={Object {}}
aria-label="Ghostery website"
className="SideNavigation__top"
href="https://ghosterystage.com"
rel="noopener noreferrer"
target="_blank"
/>
<div
className="SideNavigation__menu flex-child-grow flex-container flex-dir-column"
@@ -224,11 +224,11 @@ exports[`app/hub/Views/SideNavigationView component Snapshot tests with react-te
className="SideNavigation flex-container flex-dir-column disabled"
>
<a
aria-current="page"
className="SideNavigation__top disabled active"
href="/"
onClick={[Function]}
style={Object {}}
aria-label="Ghostery website"
className="SideNavigation__top disabled"
href="https://ghosterystage.com"
rel="noopener noreferrer"
target="_blank"
/>
<div
className="SideNavigation__menu flex-child-grow flex-container flex-dir-column"
ProTip! Use n and p to navigate between commits in a pull request.