Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2158: Subscription_type ping parameter not sending on login #606

Merged
merged 4 commits into from Sep 28, 2020
Merged

GH-2158: Subscription_type ping parameter not sending on login #606

merged 4 commits into from Sep 28, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Sep 18, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Fix race condition where subscription_type and subscription_interval ping parameters were not sending on login
@benstrumeyer
Move sign_in_success ping to Account#getUserSubscriptionData to fix r…
Loading status checks…
5592a18 
…ace condition
@benstrumeyer benstrumeyer requested a review from wlycdgr Sep 18, 2020
@benstrumeyer benstrumeyer requested review from christophertino and ghostery/extension as code owners Sep 18, 2020
@benstrumeyer benstrumeyer self-assigned this Sep 18, 2020
@benstrumeyer
Fix linter
Loading status checks…
f0897cc
@benstrumeyer benstrumeyer changed the title GH 2158: Subscription_type ping parameter not sending on login GH-2158: Subscription_type ping parameter not sending on login Sep 21, 2020
@wlycdgr
Merge in develop
Loading status checks…
5c7d5a7
@wlycdgr
wlycdgr reviewed Sep 24, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

Looks good to me. I don't love my own suggestion about moving the ping there but I don't see any other simple way of making sure that subscription data is available before we send the ping. @christophertino, what do you think?
@christophertino
Merge branch 'develop' into GH-2158
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
13cfd8b
@christophertino
christophertino approved these changes Sep 28, 2020
View changes
@christophertino christophertino merged commit 52f1a50 into develop Sep 28, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2158 branch Sep 28, 2020
@christophertino christophertino added this to the 8.5.3 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

@christophertino christophertino

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @christophertino @wlycdgr