Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2105: Sync button hover states in the hub #607

Merged
merged 4 commits into from Sep 25, 2020
Merged

GH-2105: Sync button hover states in the hub #607

merged 4 commits into from Sep 25, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Sep 22, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Apply the new $dark-ghosty-blue colors to all regular and hollow buttons with a class of button primary in the hub
  • Found regular and hollow buttons in the HomeView
  • Regular buttons in the UpgradePlanView
  • Regular buttons on the 4th page of the Customize Setup view
@benstrumeyer
Add and use mixin for button hover backgrounds in the hub
Loading status checks…
4237441
@benstrumeyer
Remove mixin...Use sass
Loading status checks…
9f294a3
@benstrumeyer
Use color variable in hub
Loading status checks…
25e9a23
@benstrumeyer benstrumeyer requested a review from wlycdgr Sep 22, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Sep 22, 2020
@benstrumeyer benstrumeyer self-assigned this Sep 22, 2020
@wlycdgr
Merge in develop
Loading status checks…
3f1760c
@wlycdgr
wlycdgr approved these changes Sep 24, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

Looks good to me
@christophertino christophertino added this to the 8.5.3 milestone Sep 25, 2020
@christophertino christophertino merged commit 653b7d4 into develop Sep 25, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2105 branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino