GH-2159: Update frequency reduction, AB test opt-out, remove Cliqz AB test #608
Conversation
…our to once a day
… with the same argument
…ke sure it always does the same thing when called with the same args
…log statement to make sure that it is triggered every time the function is called, since the message just says that the function was called
…se parts of the original it actually needs.
…tall URL. Add ts metrics query string param for whether tests are enabled. Disabled sending other AB test query string params unless tests are enabled.
|
Addresses the AB Test opt-out for #561 |
|
Anti-tracking configuration looks good. Just the ABtest is no longer used so you can remove that code. |
Verified
This commit was signed with the committer’s verified signature.
christophertino
Christopher Tino
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reduces frequency of CMP, bug DB, and AB test check from once an hour to once a day
Adds new opt-out setting for AB test participation in Settings -> Opt In/Out
Removes Cliqz antitracking AB test (
background.jscode refactored and simplified accordingly)Adds
tsquery string param to Metrics pings to signify whether user has AB tests enabledDisables sending other AB tests query string params if the user has AB tests disabled
Have you followed the guidelines in CONTRIBUTING.md?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you added an explanation of what your changes do?
Does your submission pass tests?
Did you lint your code prior to submission?