Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2177: Remove broken page pings #609

Merged
merged 3 commits into from Sep 30, 2020
Merged

GH-2177: Remove broken page pings #609

merged 3 commits into from Sep 30, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Sep 29, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • This removes the broken page pings feature implemented in #418

Ticket: https://ghostery.atlassian.net/browse/GH-2177
Related original ticket: https://ghostery.atlassian.net/browse/GH-1763
@benstrumeyer
Remove broken page functionality implemented in GH-1763
Loading status checks…
c1bb3cf
@benstrumeyer benstrumeyer requested a review from wlycdgr Sep 29, 2020
@benstrumeyer benstrumeyer requested review from christophertino and ghostery/extension as code owners Sep 29, 2020
@benstrumeyer benstrumeyer self-assigned this Sep 29, 2020
@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Sep 30, 2020

Let's take out the unused metrics imports (make sure to run the linter before PRing :) )
@wlycdgr
wlycdgr reviewed Sep 30, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM once you remove those imports
@benstrumeyer
Remove unused imports
Loading status checks…
71de5d0
@benstrumeyer benstrumeyer requested a review from wlycdgr Sep 30, 2020
@wlycdgr
wlycdgr approved these changes Sep 30, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM
@christophertino christophertino added this to the 8.5.3 milestone Sep 30, 2020
@christophertino
Merge branch 'develop' into remove-broken-page-pings
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
479062d
@christophertino
christophertino approved these changes Sep 30, 2020
View changes
@christophertino christophertino merged commit 73318a0 into develop Sep 30, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the remove-broken-page-pings branch Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
None yet
Projects
None yet
Milestone
8.5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino