Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2158: Subscription_type ping parameter not sending on login #610

Merged
merged 4 commits into from Oct 2, 2020
Merged

GH-2158: Subscription_type ping parameter not sending on login #610

merged 4 commits into from Oct 2, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Sep 30, 2020 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

The sign_in_success ping is not being fired when signing in with a free account. This is because the .then() chain on the getUserSubscriptionData() api call will not run if a user does not have any subscriptions. Let's add a finally block to make sure the ping runs regardless of what is returned from that call

Ticket: https://ghostery.atlassian.net/browse/GH-2158
@benstrumeyer
Ensure sign_in_success ping fires for free accounts as well as plus a…
Loading status checks…
f366dba 
…nd premium
@benstrumeyer
Merge branch 'develop' into GH-2158
Loading status checks…
be23491
@benstrumeyer benstrumeyer requested a review from wlycdgr Sep 30, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Sep 30, 2020
@benstrumeyer benstrumeyer self-assigned this Sep 30, 2020
@benstrumeyer
Pacify linter
Loading status checks…
3858f87
@wlycdgr
wlycdgr approved these changes Sep 30, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM. I am now seeing the ping being sent when logging in with a free account.
@christophertino christophertino added this to the 8.5.3 milestone Oct 2, 2020
@christophertino
Merge branch 'develop' into GH-2158
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3e812f1
@christophertino christophertino merged commit 98895ab into develop Oct 2, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@christophertino christophertino deleted the GH-2158 branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino