Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2158: Subscription_type ping parameter not sending on login #610

Merged
merged 4 commits into from Oct 2, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Merge branch 'develop' into GH-2158

  • Loading branch information
benstrumeyer committed Sep 30, 2020
commit be234918dd6efcaaedd36ffd50e7c98e2d5d8f34
@@ -88,7 +88,7 @@ class Account {
ghosteryDebugger.addAccountEvent('login', 'cookie set by fetch POST');
this._getUserIDFromCookie().then((userID) => {
this._setAccountInfo(userID);
this.getUserSubscriptionData({ calledFrom: 'login'});
this.getUserSubscriptionData({ calledFrom: 'login' });
});
return {};
});
@@ -169,7 +169,7 @@ class Account {
/**
* @return {array} All subscriptions the user has, empty if none
*/
getUserSubscriptionData = (options) => (
getUserSubscriptionData = options => (
this._getUserID()
.then(userID => api.get('stripe/customers', userID, 'cards,subscriptions'))
.then((res) => {
@@ -196,9 +196,6 @@ class Account {
this._setSubscriptionData(plusSubscription);
}
}
if (options && options.calledFrom === 'login') {
metrics.ping('sign_in_success');
}

return subscriptions;

You are viewing a condensed version of this merge commit. You can view the full changes here.
ProTip! Use n and p to navigate between commits in a pull request.