Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2097/t2-to-utm-content-fix #612

Merged
merged 5 commits into from Oct 2, 2020
Merged

GH-2097/t2-to-utm-content-fix #612

merged 5 commits into from Oct 2, 2020

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Oct 1, 2020 •
edited

  • Removes t2 Metrics ping param
  • Adds utm_content param to CTA button links in the Hub to let us know whether the clicks are coming from alternate or default Hub

[X ] Have you followed the guidelines in CONTRIBUTING.md?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Have you added an explanation of what your changes do?
[X] Does your submission pass tests?
[X] Did you lint your code prior to submission?
wlycdgr added 2 commits Oct 1, 2020
@wlycdgr
Remove t2 code from Metrics
0c5ad05
@wlycdgr
Add utm_content
Loading status checks…
1010e63
@wlycdgr wlycdgr requested a review from benstrumeyer as a code owner Oct 1, 2020
@wlycdgr
Pacify linter
Loading status checks…
01bfeed
@wlycdgr wlycdgr requested a review from leuryr Oct 1, 2020
@wlycdgr
Modify ah comment in UpgradePlan
Loading status checks…
59b8981
@leuryr
leuryr approved these changes Oct 1, 2020
View changes
Copy link
Contributor

@leuryr leuryr left a comment

Lgtm.
@christophertino christophertino added this to the 8.5.3 milestone Oct 2, 2020
@christophertino
Merge branch 'develop' into GH-2097/t2-to-utm-content-fix
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
a215839
@christophertino
christophertino approved these changes Oct 2, 2020
View changes
@christophertino christophertino merged commit 5b86f6c into develop Oct 2, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@christophertino christophertino deleted the GH-2097/t2-to-utm-content-fix branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@leuryr leuryr

@benstrumeyer benstrumeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wlycdgr @christophertino @leuryr