Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2097/t2-to-utm-content-fix #612

Merged
merged 5 commits into from Oct 2, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next

Remove t2 code from Metrics

  • Loading branch information
wlycdgr committed Oct 1, 2020
commit 0c5ad05f8474c8ee50d0f67fb885f91089cb7a4b
@@ -296,11 +296,6 @@ class Metrics {
// AB tests enabled?
`&ts=${encodeURIComponent(conf.enable_abtests ? '1' : '0')}`;

if (conf.enable_abtests) {
// Hub Layout A/B test. Added in 8.5.3. GH-2097, GH-2100
metrics_url += `&t2=${encodeURIComponent(Metrics._getHubLayoutView().toString())}`;
}

if (CAMPAIGN_METRICS.includes(type)) {
// only send campaign attribution when necessary
metrics_url +=
@@ -451,25 +446,6 @@ class Metrics {
}
}

/**
* Get the Int associated with the Hub layout view shown on install
* @private
* @return {number} Int associated with the Hub layout view
*/
static _getHubLayoutView() {
const { hub_layout } = conf;

switch (hub_layout) {
case 'default':
return 1;
case 'alternate':
return 2;
case 'not_yet_set':
default:
return 0;
}
}

/**
* Get the Int associated with the users subscription interval
* @private
ProTip! Use n and p to navigate between commits in a pull request.