Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(8.5.4) GH-2166: Update name of Unknown category #613

Merged
merged 9 commits into from Oct 27, 2020
Merged

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Oct 1, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Update name of unknown category

Ticket: https://ghostery.atlassian.net/browse/GH-2166

benstrumeyer added 2 commits Oct 1, 2020
@benstrumeyer benstrumeyer added this to the 8.5.4 milestone Oct 1, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Oct 1, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Oct 1, 2020
@benstrumeyer benstrumeyer self-assigned this Oct 1, 2020
@wlycdgr wlycdgr changed the title GH-2166: Update name of Unknown category (DNM UNTIL 8.5.3 IS OUT) GH-2166: Update name of Unknown category Oct 2, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

Same deal here as with GH-2178: let's update the variable names in the code to try to keep everything consistent. There are a lot of places where we use unknown but the large majority of them look like they should be a straightforward search&replace situation.

Bigger picture, we should think about whether there might be a safer and more efficient way we can keep this stuff in sync. It would def be better if we could make these kind of copy updates without needing to manually update a bunch of code like this.

@benstrumeyer benstrumeyer requested a review from wlycdgr Oct 6, 2020
@wlycdgr wlycdgr changed the title (DNM UNTIL 8.5.3 IS OUT) GH-2166: Update name of Unknown category (8.5.4) GH-2166: Update name of Unknown category Oct 7, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

The panel's unkown.svg file also needs to be renamed - right now the icon is broken cos it's looking for unidentified.svg

CHANGELOG.md Outdated Show resolved Hide resolved
@benstrumeyer benstrumeyer requested a review from wlycdgr Oct 27, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM

@christophertino christophertino merged commit 0d8cd38 into develop Oct 27, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2166 branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants