Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(8.5.4) GH-2153: Future-proof metrics uninstall URL #615

Merged
merged 7 commits into from Oct 26, 2020
Merged

(8.5.4) GH-2153: Future-proof metrics uninstall URL #615

merged 7 commits into from Oct 26, 2020
+77 −61

Conversation

@leuryr
Copy link
Contributor

@leuryr leuryr commented Oct 1, 2020 •
edited

Shortens the query string for the uninstall URL by including only the ping params we've deemed as crucial.

I've also added a helper method for constructing the query string key value pairs, which hopefully makes it a little easier to read/identify the queries and values getting added to metrics_url, and helps prevent potential errors when adding new params.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
leuryr added 2 commits Oct 1, 2020
@leuryr
Use only crucial params for uninstall type
a3b2e53
@leuryr
Move some query string construction to helper
Loading status checks…
7f6986e
@leuryr leuryr requested a review from wlycdgr as a code owner Oct 1, 2020
@christophertino christophertino added this to the 8.5.4 milestone Oct 2, 2020
@wlycdgr wlycdgr changed the title GH-2153: Future-proof metrics uninstall URL (DNM UNTIL 8.5.3 IS OUT) GH-2153: Future-proof metrics uninstall URL Oct 2, 2020
@leuryr
Merge branch 'develop' into GH-2153/metrics-url
Loading status checks…
0259aa6
@wlycdgr
wlycdgr reviewed Oct 2, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

Quick version bump on the helper JSDoc
Also, while we're here, might be nice to move the definition of METRICS_URL_SET out of setUninstallUrl. No reason to re-initialize that constant every time.
src/classes/Metrics.js Outdated
*
* @private
*
* @since 8.5.3

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr Oct 2, 2020
Member

My bad, let's bump this to 8.5.4
leuryr added 2 commits Oct 5, 2020
@leuryr
Group METRICS_URL_SET with other consts
Loading status checks…
5cb0543
@leuryr
Syntax fix
Loading status checks…
0d8b3cd
@wlycdgr wlycdgr changed the title (DNM UNTIL 8.5.3 IS OUT) GH-2153: Future-proof metrics uninstall URL (8.5.4) GH-2153: Future-proof metrics uninstall URL Oct 7, 2020
@wlycdgr
Merge in develop
Loading status checks…
119f6a1
@wlycdgr
wlycdgr reviewed Oct 26, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

Latest changes looks good
@wlycdgr
wlycdgr approved these changes Oct 26, 2020
View changes
@christophertino
Merge branch 'develop' into GH-2153/metrics-url
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
23da454
@christophertino christophertino merged commit 86b4f20 into develop Oct 26, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2153/metrics-url branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@leuryr @wlycdgr @christophertino