Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(8.5.4) GH-2153: Future-proof metrics uninstall URL #615

Merged
merged 7 commits into from Oct 26, 2020

Merge branch 'develop' into GH-2153/metrics-url

  • Loading branch information
leuryr committed Oct 2, 2020
commit 0259aa65055afc2dbee7b5a16b03c8475debb438
@@ -312,11 +312,6 @@ class Metrics {
// New parameter for Ghostery 8.5.3
// AB tests enabled?
this._buildQueryPair('ts', conf.enable_abtests ? '1' : '0');

if (conf.enable_abtests) {
// Hub Layout A/B test. Added in 8.5.3. GH-2097, GH-2100
metrics_url += this._buildQueryPair('t2', Metrics._getHubLayoutView().toString());
}
}

if (CAMPAIGN_METRICS.includes(type) || type === 'uninstall') {
@@ -326,13 +321,8 @@ class Metrics {
this._buildQueryPair('us', this.utm_source) +
// Marketing campaign (Former utm_campaign)
this._buildQueryPair('uc', this.utm_campaign);
} else if (type === 'broken_page' && this._brokenPageWatcher.on && type !== 'uninstall') {
metrics_url +=
// What triggered the broken page ping?
this._buildQueryPair('setup_path', this._brokenPageWatcher.triggerId.toString()) +
// How much time passed between the trigger and the page refresh / open in new tab?
this._buildQueryPair('setup_block', (Date.now() - this._brokenPageWatcher.triggerTime).toString());
}

return metrics_url;
}

You are viewing a condensed version of this merge commit. You can view the full changes here.
ProTip! Use n and p to navigate between commits in a pull request.