Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(8.5.4) GH-2186: Always open promo modal links in same window as panel #617

Merged
merged 2 commits into from Oct 26, 2020
Merged

(8.5.4) GH-2186: Always open promo modal links in same window as panel #617

merged 2 commits into from Oct 26, 2020

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Oct 6, 2020

Fixes bug where promo modal links would open in whatever browser window is active, regardless of whether it's the one with the panel

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
For clicks from promo modals, always open links in same window as panel
Loading status checks…
3108b16
@wlycdgr wlycdgr requested a review from christophertino Oct 6, 2020
@christophertino christophertino added this to the 8.5.3 milestone Oct 6, 2020
@christophertino
christophertino approved these changes Oct 6, 2020
View changes
@christophertino christophertino modified the milestones: 8.5.3, 8.5.4 Oct 7, 2020
@wlycdgr wlycdgr changed the title GH-2186: Always open promo modal links in same window as panel (8.5.4) GH-2186: Always open promo modal links in same window as panel Oct 7, 2020
@ghostery ghostery deleted a comment from jmlh556 Oct 19, 2020
@wlycdgr
Merge in develop
Loading status checks…
4c32536
@christophertino christophertino merged commit f3502fc into develop Oct 26, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2186/promo-modal-buttons-fix branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino