Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2097 bugfix: make sure alternate Hub view is used when expected #619

Merged
merged 1 commit into from Oct 7, 2020
Merged

GH-2097 bugfix: make sure alternate Hub view is used when expected #619

merged 1 commit into from Oct 7, 2020

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Oct 7, 2020

Fixes a bug that made ABTest clients always think the tests had not been fetched yet.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Fix bug that always made ABTest clients think tests had not been fetc…
Loading status checks…
45832c2 
…hed yet
@wlycdgr wlycdgr requested review from benstrumeyer and christophertino Oct 7, 2020
@christophertino
christophertino approved these changes Oct 7, 2020
View changes
@christophertino christophertino added this to the 8.5.3 milestone Oct 7, 2020
@christophertino christophertino merged commit 2af07ea into develop Oct 7, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2097/bugfix/ensure-alternate-view-displays branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@benstrumeyer benstrumeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino