Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-2188 - Adjustments for Ghostery Browser #622
GH-2188 - Adjustments for Ghostery Browser #622
Changes from 1 commit
11d8b025bf5c4525f945df3affd3ad026c1File filter
Jump to
update setting for Ghostery Browser
Verified
sammacbethOct 23, 2020
Contributor
So we completely disable access to the hub page on the browser? Would it not be useful for some users who may want to access it later?
christophertinoOct 23, 2020
Author
Member
We would need to adjust opt-in default settings for the hub but it's doable.
christophertinoOct 23, 2020
Author
Member
Fixed
sammacbethOct 23, 2020
Contributor
Should this be here?
christophertinoOct 23, 2020
Author
Member
yea it's fine for
develop. It gets removed by the builder.sammacbethOct 23, 2020
Contributor
Is there a potential race here? How early is this block evaluated in the startup? The browser name will not be correct until after
chrome.runtime.getBrowserInfohas resolved.christophertinoOct 23, 2020
Author
Member
This evaluates pretty far down the init chain and is nested inside
cliqz.start(). The line directly below uses a similar check for android and has been working ok. But I admit I don't love this implementation. Open to suggestions.sammacbethOct 23, 2020
Contributor
We could attach a
Globals.browserInfoReadyPromise inGlobalswhen we callbuildBrowserInfo, which we can then justawaitat these points that need to be sure that the browser check has been done.sammacbethOct 23, 2020
Contributor
Again, could this be a race?
christophertinoOct 23, 2020
Author
Member
Same as above, it does evaluate in order but the possibility for a race condition technically exists.