Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2170: Do not show setup override warning for first-time, signed out users #624

Merged
merged 2 commits into from Oct 27, 2020
Merged

GH-2170: Do not show setup override warning for first-time, signed out users #624

merged 2 commits into from Oct 27, 2020

Conversation

@leuryr
Copy link
Contributor

@leuryr leuryr commented Oct 26, 2020 •
edited

Fix for object returning from QueryString.parse(window.location.search) in SetupViewContainer.jsx that was causing a bug in the setup warning modal logic.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@leuryr
Fix object getting passed to modal logic
Loading status checks…
11f1bf9
@leuryr leuryr requested review from christophertino and ghostery/extension as code owners Oct 26, 2020
@leuryr leuryr requested a review from wlycdgr Oct 26, 2020
@wlycdgr
Merge in develop
Loading status checks…
957f401
@wlycdgr
wlycdgr approved these changes Oct 27, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM
@christophertino christophertino added this to the 8.5.4 milestone Oct 27, 2020
@christophertino
christophertino approved these changes Oct 27, 2020
View changes
@christophertino christophertino merged commit 33d3b24 into develop Oct 27, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2170/setup-warning branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@leuryr @christophertino @wlycdgr