Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2170: Do not show setup override warning for first-time, signed out users #624

Merged
merged 2 commits into from Oct 27, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next

Fix object getting passed to modal logic

  • Loading branch information
leuryr committed Oct 26, 2020
commit 11f1bf9ccdcbf817bdf07ac11de396f7478ef1ce
@@ -1760,7 +1760,7 @@ function initializeGhosteryModules() {
const showAlternateHub = conf.hub_layout === 'alternate';
const route = showAlternateHub ? '#home' : '';
chrome.tabs.create({
url: chrome.runtime.getURL(`./app/templates/hub.html?$justInstalled=true&ah=${showAlternateHub}${route}`),
url: chrome.runtime.getURL(`./app/templates/hub.html?justInstalled=true&ah=${showAlternateHub}${route}`),
active: true
});
}
@@ -802,7 +802,7 @@ class Debugger {
openIntroHub = (modal = '') => {
const showModal = modal.toLowerCase() === 'modal';
chrome.tabs.create({
url: chrome.runtime.getURL(`./app/templates/hub.html?$justInstalled=true&pm=${showModal}`),
url: chrome.runtime.getURL(`./app/templates/hub.html?justInstalled=true&pm=${showModal}`),
active: true
});
return THANKS;
ProTip! Use n and p to navigate between commits in a pull request.