Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2189: Learn More link takes you to Ghostery Image url instead of site #625

Merged
merged 14 commits into from Oct 28, 2020
Merged

GH-2189: Learn More link takes you to Ghostery Image url instead of site #625

merged 14 commits into from Oct 28, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Oct 27, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Replace https://www.ghostery.com/products/plus with https://www.ghostery.com/pricing in:
  • PromoModal.jsx
  • Subscribe.jsx
  • Historical Stats CTA link in Stats.jsx (Also updated Historical Stats Learn more link in description)

85e305ed-9308-4156-a3ce-f0dc8914d64c

Ticket: https://ghostery.atlassian.net/browse/GH-2189
wlycdgr and others added 6 commits Oct 9, 2020
@wlycdgr
Update Learn More link in the upgrade banner promo modal
Loading status checks…
691e7cf
@benstrumeyer
Merge branch 'develop' into GH-2189
f685166
@benstrumeyer
Change learn more link in PromoModals.jsx
cba2a00
@benstrumeyer
Change checkout page in Subscribe.jsx and Stats.jsx
Loading status checks…
5ad0534
@benstrumeyer
Update historical stats learn more link
4c9e9b0
@benstrumeyer
Remove / to make query params consistent
Loading status checks…
d404814
@benstrumeyer benstrumeyer added this to the 8.5.4 milestone Oct 27, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Oct 27, 2020
@benstrumeyer benstrumeyer requested review from christophertino and ghostery/extension as code owners Oct 27, 2020
@benstrumeyer benstrumeyer self-assigned this Oct 27, 2020
@wlycdgr
Merge in develop
Loading status checks…
ed8325c
@wlycdgr
wlycdgr reviewed Oct 27, 2020
View changes
app/panel/components/Subscribe.jsx Outdated Show resolved Hide resolved
_locales/en/messages.json Outdated Show resolved Hide resolved
@benstrumeyer
Update link in Subscribe.jsx to use the GHOSTERY_BASE_URL and add bac…
7a8e449 
…k utm params
@benstrumeyer
Use GHOSTERY_BASE_URL in StatsView.jsx
ae8c66f
@benstrumeyer
Underline learn more
d98467a
@benstrumeyer benstrumeyer requested a review from wlycdgr Oct 28, 2020
benstrumeyer and others added 3 commits Oct 28, 2020
@benstrumeyer
Merge branch 'GH-2189' of github.com:ghostery/ghostery-extension into…
Loading status checks…
4a68913 
… GH-2189
@benstrumeyer
Add utm parameters to learn more link in StatsView.jsx
Loading status checks…
f3a42ec
@wlycdgr
Merge in develop
Loading status checks…
389a4b9
@wlycdgr
wlycdgr approved these changes Oct 28, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM
@christophertino
Merge branch 'develop' into GH-2189
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3f40017
@christophertino christophertino merged commit e441896 into develop Oct 28, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2189 branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

@christophertino christophertino

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino