Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2189: Learn More link takes you to Ghostery Image url instead of site #625

Merged
merged 14 commits into from Oct 28, 2020
+21 −21
Merged

GH-2189: Learn More link takes you to Ghostery Image url instead of site #625

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
691e7cf
Update Learn More link in the upgrade banner promo modal
wlycdgr Oct 9, 2020
f685166
Merge branch 'develop' into GH-2189
benstrumeyer Oct 27, 2020
cba2a00
Change learn more link in PromoModals.jsx
benstrumeyer Oct 27, 2020
5ad0534
Change checkout page in Subscribe.jsx and Stats.jsx
benstrumeyer Oct 27, 2020
4c9e9b0
Update historical stats learn more link
benstrumeyer Oct 27, 2020
d404814
Remove / to make query params consistent
benstrumeyer Oct 27, 2020
ed8325c
Merge in develop
wlycdgr Oct 27, 2020
7a8e449
Update link in Subscribe.jsx to use the GHOSTERY_BASE_URL and add bac…
benstrumeyer Oct 28, 2020
ae8c66f
Use GHOSTERY_BASE_URL in StatsView.jsx
benstrumeyer Oct 28, 2020
d98467a
Underline learn more
benstrumeyer Oct 28, 2020
4a68913
Merge branch 'GH-2189' of github.com:ghostery/ghostery-extension into…
benstrumeyer Oct 28, 2020
f3a42ec
Add utm parameters to learn more link in StatsView.jsx
benstrumeyer Oct 28, 2020
389a4b9
Merge in develop
wlycdgr Oct 28, 2020
3f40017
Merge branch 'develop' into GH-2189
christophertino Oct 28, 2020
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next

Update historical stats learn more link

  • Loading branch information
@benstrumeyer
benstrumeyer committed Oct 27, 2020
commit 4c9e9b09fc2706cc38ccd1b1cf7d199c9b861bca
2 _locales/en/messages.json
View file
Open in desktop
@@ -2099,7 +2099,7 @@
"content": "</a>"
},
"link_start": {
"content": "<br><a target=\"_blank\" rel=\"noopener noreferrer\" href=\"https://www.ghostery.com/products/plus?utm_source=gbe&utm_campaign=in_app_hstats_lm\">"
"content": "<br><a target=\"_blank\" rel=\"noopener noreferrer\" href=\"https://www.ghostery.com/pricing?utm_source=gbe&utm_campaign=in_app_hstats_lm\">"
This conversation was marked as resolved by wlycdgr

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr Oct 27, 2020
Member

Let's update this to use GHOSTERY_BASE_URL too, if you can figure out a way to do this that doesn't require too much reworking of the code. Maybe this link can be pulled out of the string and instead be implemented in the component as a PanelToTabLink?

This comment has been minimized.

Sign in to view
@benstrumeyer

benstrumeyer Oct 28, 2020
Author Contributor

Good idea. Refactored to use PanelToTabLink!
}
}
},
ProTip! Use n and p to navigate between commits in a pull request.