Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2189: Learn More link takes you to Ghostery Image url instead of site #625

Merged
merged 14 commits into from Oct 28, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Use GHOSTERY_BASE_URL in StatsView.jsx

  • Loading branch information
benstrumeyer committed Oct 28, 2020
commit ae8c66f4261e3e16ec3e05887a8049935e934f50
@@ -2087,21 +2087,7 @@
"message": "No, Keep History"
},
"panel_stats_pitch_modal_text": {
"message": "Unlock your historical stats (and other cool perks) by upgrading to Ghostery Plus.$LINK_START$Learn More$LINK_END$",
"placeholders": {
"span_start": {
"content": "<span>"
},
"span_end": {
"content": "</span>"
},
"link_end": {
"content": "</a>"
},
"link_start": {
"content": "<br><a target=\"_blank\" rel=\"noopener noreferrer\" href=\"https://www.ghostery.com/pricing?utm_source=gbe&utm_campaign=in_app_hstats_lm\">"
}
}
"message": "Unlock your historical stats (and other cool perks) by upgrading to Ghostery Plus."
},
"panel_stats_pitch_modal_already": {
"message": "Already a Ghostery Supporter?"
@@ -16,7 +16,10 @@ import ClassNames from 'classnames';
import { ReactSVG } from 'react-svg';

import StatsGraph from './BuildingBlocks/StatsGraph';
import I18nWithLink from '../../shared-components/I18nWithLink';
import PanelToTabLink from './BuildingBlocks/PanelToTabLink';
import globals from '../../../src/classes/Globals';

const { GHOSTERY_BASE_URL } = globals;

/**
* A Functional React component for rendering the Stats View
@@ -193,8 +196,11 @@ const StatsView = (props) => {
<div className="modal-container">
<div className="modal-content">
<div className="modal-text-container">
<I18nWithLink cssClasses="modal-title-text" value="panel_stats_pitch_modal_text" />
<div className="modal-title-text">{ t('panel_stats_pitch_modal_text') }</div>
</div>
<PanelToTabLink href={`${GHOSTERY_BASE_URL}/pricing/?utm_source=gbe&utm_campaign=in_app_plus_lm`}>
<span className="pitch-learn-more">{t('learn_more')}</span>
</PanelToTabLink>
<div className="modal-buttons-container">
<div className="modal-filled-button" onClick={subscribe}>{t('get_ghostery_plus_bang')}</div>
</div>
@@ -254,6 +254,10 @@
font-weight: normal;
}
}
.pitch-learn-more {
display: flex;
justify-content: center;
}
}
.modal-buttons-container {
display: flex;
ProTip! Use n and p to navigate between commits in a pull request.