Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2191: Update purple box text to tracker tally #627

Merged
merged 4 commits into from Oct 28, 2020
Merged

GH-2191: Update purple box text to tracker tally #627

merged 4 commits into from Oct 28, 2020

Conversation

@leuryr
Copy link
Contributor

@leuryr leuryr commented Oct 27, 2020

  • Updates the "purple box" user facing references to the new "tracker-tally" wording.
  • Removes some strings that weren't being used.
  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
leuryr added 2 commits Oct 27, 2020
@leuryr
Change user-facing purple box to tracker tally
Loading status checks…
ca35ebf
@leuryr
Remove strings that were no longer being used
Loading status checks…
9e0f9c1
@leuryr leuryr requested a review from ghostery/extension as a code owner Oct 27, 2020
@christophertino christophertino added this to the 8.5.4 milestone Oct 28, 2020
@christophertino
christophertino requested changes Oct 28, 2020
View changes
_locales/en/messages.json Outdated Show resolved Hide resolved
@leuryr
Revert key names changes
Loading status checks…
077b96b
@christophertino
christophertino approved these changes Oct 28, 2020
View changes
@christophertino
Merge branch 'develop' into GH-2191/tracker-tally
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
d98bd98
@christophertino christophertino merged commit 6185e88 into develop Oct 28, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2191/tracker-tally branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@leuryr @christophertino