Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2186: Hub Home view bug fix #628

Merged
merged 4 commits into from Oct 28, 2020
Merged

GH-2186: Hub Home view bug fix #628

merged 4 commits into from Oct 28, 2020

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Oct 27, 2020

Fixes a bug in the GH-2186 implementation that was causing the PromoModal component to break Hub views that use it.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr added 4 commits Oct 6, 2020
@wlycdgr
For clicks from promo modals, always open links in same window as panel
Loading status checks…
3108b16
@wlycdgr
Merge in develop
Loading status checks…
4c32536
@wlycdgr
Merge in develop
Loading status checks…
763c481
@wlycdgr
Fix Hub Home view breaking bug
Loading status checks…
3d93154
@wlycdgr wlycdgr requested review from benstrumeyer and christophertino Oct 28, 2020
@christophertino christophertino added this to the 8.5.4 milestone Oct 28, 2020
@christophertino
christophertino approved these changes Oct 28, 2020
View changes
@christophertino christophertino merged commit 11c60ac into develop Oct 28, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2186/promo-modal-buttons-fix branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@benstrumeyer benstrumeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino