Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2173: Account#getUserSettings() failure handling #629

Merged
merged 1 commit into from Nov 5, 2020
Merged

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Nov 4, 2020

Handle the case where Account#getUserSettings() fails because user settings have never been synced to the account server, which will be the case for a user who creates a new account until they change a setting for the first time.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
…have never been synced to account server
@wlycdgr wlycdgr requested a review from ghostery/extension as a code owner Nov 4, 2020
@christophertino christophertino added this to the 8.5.4 milestone Nov 5, 2020
@christophertino christophertino merged commit b9afca1 into develop Nov 5, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2173 branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants