Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2173: Account#getUserSettings() failure handling #629

Merged
merged 1 commit into from Nov 5, 2020
Merged
Changes from all commits
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Handle the case where Account#getUserSettings fails because settings …

…have never been synced to account server
  • Loading branch information
Ilya Zarembsky
Ilya Zarembsky committed Nov 4, 2020
commit e94a0156696dcb831a01eb5396349cee167713e5
@@ -164,6 +164,10 @@ class Account {
this._setAccountUserSettings(settings_json);
return settings_json;
})
// Fetching the settings from the account server failed,
// or they have simply never been synced to the account server yet
// In that case, just use the local settings
.catch(() => this.buildUserSettings())
)

/**
ProTip! Use n and p to navigate between commits in a pull request.