GH-2216: Disable setup sidebar link on fourth page of setup #631
Conversation
| // Disable the sidebar link that leads to a blank screen on custom setup page 4 (GH-2216) | ||
| const shouldDisableSetupLink = (window.location.href.indexOf('setup/4') > -1) && (item.href.substring(1) === 'setup'); | ||
|
|
Comment on lines
32
to
34
wlycdgr
Nov 13, 2020
Member
Let's instead modify the disableRegEx in the render() method of sideNavigationViewContainer. That way we don't need to add new code or unnecessarily test every sidebar item. I think it's ok that users can't navigate away to other tabs from that screen without pressing "Done".
Let's instead modify the disableRegEx in the render() method of sideNavigationViewContainer. That way we don't need to add new code or unnecessarily test every sidebar item. I think it's ok that users can't navigate away to other tabs from that screen without pressing "Done".
benstrumeyer
Nov 13, 2020
Author
Contributor
That makes sense, updated!
That makes sense, updated!
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ticket: https://ghostery.atlassian.net/browse/GH-2216