GH-2222 - Handle updated Chrome new tab page url #632
Merged
Conversation
christophertino
requested review from
benstrumeyer and
ghostery/extension
as
code owners
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The Chrome new tab url is now chrome://new-tab-page. Prior to Chrome 75 the url was https://www.google.com/_/chrome/newtab. For Purplebox and Click2Play, we only inject on http/s pages. We still check for
_/chrome/newtabas a fallback for legacy users.