Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2216: Disable sidebar links on last page of Tutorial and Customize Setup in the hub #634

Merged
merged 1 commit into from Nov 20, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Nov 20, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Modify the disableRegEx in the render() method of sideNavigationViewContainer.jsx to disable the sidebar links

Ticket: https://ghostery.atlassian.net/browse/GH-2216

@benstrumeyer benstrumeyer added this to the 8.5.4 milestone Nov 20, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Nov 20, 2020
@benstrumeyer benstrumeyer self-assigned this Nov 20, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM

@christophertino christophertino merged commit 8f6e1c9 into develop Nov 20, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2216 branch Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants