Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2205: Onboarding - Welcome & Get Started #637

Merged
merged 6 commits into from Dec 3, 2020
Merged

GH-2205: Onboarding - Welcome & Get Started #637

merged 6 commits into from Dec 3, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Dec 3, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Create welcome onboarding view page

Ticket: https://ghostery.atlassian.net/browse/GH-2205
@benstrumeyer
Make browser welcome view
6f4addc
@benstrumeyer
Add cta button
e5fefb7
@benstrumeyer
Change CTA button to a button
e0a4254
@benstrumeyer
Merge branch 'GH-2205' into ghostery-browser-intro-hub
Loading status checks…
c557caf
@benstrumeyer
Add comment
Loading status checks…
c89d715
@benstrumeyer
Remove redux connection
Loading status checks…
741bf1c
@benstrumeyer benstrumeyer requested a review from wlycdgr Dec 3, 2020
@benstrumeyer benstrumeyer self-assigned this Dec 3, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Dec 3, 2020
@wlycdgr
wlycdgr approved these changes Dec 3, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

Looks good for pulling in and working with
@wlycdgr wlycdgr merged commit a51e0ae into ghostery-browser-intro-hub Dec 3, 2020
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@benstrumeyer benstrumeyer deleted the GH-2205 branch Jan 29, 2021
@christophertino christophertino added this to the 8.5.5 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Feature Request
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino