Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2206: Onboarding - Step 1 - Create Account #639

Merged
merged 36 commits into from Dec 7, 2020
Merged

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Dec 5, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Make Step1_CreateAccountView which is a parent component for Step1_CreateAccountForm and Step1_LogInForm
  • Step1_CreateAccountForm copies validation logic from CreateAccountForm in the hub and adds Confirm Password
  • A throttle is added for clicking Forgot Password and uses the email entered in the email field (per vinny), Our backend already throttles requests, but returns an error in the form of a toast if spammed which this hopefully prevents in most cases. Set to 3000 since we still want the user to be able to click Forgot Password after entering a wrong email
  • Send updates and promotions checkbox copies logic from account-web to add user.emailPreferences.globals = true to the user state
  • Both screens are responsive
  • If a user is already signed in, a screen will be shown with a button to skip past this step

Ticket: https://ghostery.atlassian.net/browse/GH-2206

benstrumeyer added 30 commits Dec 1, 2020
benstrumeyer added 6 commits Dec 4, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Dec 5, 2020
@benstrumeyer benstrumeyer self-assigned this Dec 5, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Dec 5, 2020
@wlycdgr
wlycdgr approved these changes Dec 7, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM for merging into intermediate branch purposes

@wlycdgr wlycdgr merged commit 9799389 into ghostery-browser-intro-hub Dec 7, 2020
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@benstrumeyer benstrumeyer deleted the GH-2206 branch Jan 29, 2021
@christophertino christophertino added this to the 8.5.5 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants